paulandClaude Opus 4.8
7c695be590
The Odesli/Songlink API rejects artist URLs (405 UNSUPPORTED_URL — it is song/album only), so the planned Odesli hop is not viable for artist linking. Pivoted to MusicBrainz `inc=url-rels`, which returns the artist's official Bandcamp + Spotify URLs directly, zero-cred: - service/lib.js: relUrls() extracts direct bandcamp/spotify from MB relations; mbResult() prefers them, falls back to search URLs per-platform (replaces searchResult). - service/resolver.js: viaMusicBrainz now does search -> url-rels enrichment (both throttled through one gate); resolveOne calls it directly. - service/lib.test.js: +3 tests (relUrls + mbResult); 9 total, green. - README: document the direct-link behavior. Verified zero-cred end to end: "Cattle Decapitation" -> open.spotify.com/artist/... + cattledecapitation.bandcamp.com/ (both direct, not search); nonsense -> null. Source: task/odesli-direct-links (objective/linker-improvements); approach changed from Odesli to MB url-rels after the API probe; goal (direct Bandcamp) achieved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
81 lines
3.7 KiB
JavaScript
81 lines
3.7 KiB
JavaScript
// Unit tests for the resolver's pure logic (run with `node --test`). Zero-dep.
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { norm, bandcampSearch, spotifySearch, pickArtist, spotifyResult, relUrls, mbResult } from "./lib.js";
|
|
|
|
test("norm lowercases, trims, NFKC-normalizes", () => {
|
|
assert.equal(norm(" Cerebral Bore "), "cerebral bore");
|
|
assert.equal(norm("DEVOURMENT"), "devourment");
|
|
});
|
|
|
|
test("pickArtist matches case-insensitively, rejects non-matches", () => {
|
|
const items = [{ name: "Cattle Decapitation" }, { name: "Cerebral Bore" }];
|
|
assert.equal(pickArtist("cerebral bore", items)?.name, "Cerebral Bore");
|
|
assert.equal(pickArtist("CATTLE DECAPITATION", items)?.name, "Cattle Decapitation");
|
|
assert.equal(pickArtist("Notarealband", items), null);
|
|
});
|
|
|
|
test("pickArtist enforces minScore when given (MusicBrainz path)", () => {
|
|
const items = [{ name: "Devourment", score: 100 }, { name: "Devourment", score: 50 }];
|
|
assert.equal(pickArtist("Devourment", items, { minScore: 90 })?.score, 100);
|
|
assert.equal(pickArtist("Devourment", [{ name: "Devourment", score: 50 }], { minScore: 90 }), null);
|
|
});
|
|
|
|
test("pickArtist tolerates empty / garbage input", () => {
|
|
assert.equal(pickArtist("x", null), null);
|
|
assert.equal(pickArtist("x", []), null);
|
|
assert.equal(pickArtist("x", [null, { name: "y" }]), null);
|
|
});
|
|
|
|
test("spotifyResult prefers the direct url, falls back to search", () => {
|
|
const direct = spotifyResult({
|
|
name: "Devourment",
|
|
external_urls: { spotify: "https://open.spotify.com/artist/abc" },
|
|
});
|
|
assert.equal(direct.spotify, "https://open.spotify.com/artist/abc");
|
|
assert.match(direct.bandcamp, /^https:\/\/bandcamp\.com\/search\?q=Devourment/);
|
|
|
|
const noUrl = spotifyResult({ name: "Devourment" });
|
|
assert.equal(noUrl.spotify, "https://open.spotify.com/search/Devourment");
|
|
});
|
|
|
|
test("relUrls picks direct bandcamp + spotify from MB relations, tolerates junk", () => {
|
|
const relations = [
|
|
{ url: { resource: "https://cattledecapitation.bandcamp.com/" } },
|
|
{ url: { resource: "https://open.spotify.com/artist/67ZMMtA88DDO0gTuRrzGjn" } },
|
|
{ url: { resource: "https://en.wikipedia.org/wiki/Cattle_Decapitation" } },
|
|
null,
|
|
{ url: null },
|
|
];
|
|
const links = relUrls(relations);
|
|
assert.equal(links.bandcamp, "https://cattledecapitation.bandcamp.com/");
|
|
assert.equal(links.spotify, "https://open.spotify.com/artist/67ZMMtA88DDO0gTuRrzGjn");
|
|
});
|
|
|
|
test("relUrls returns nulls when relations absent/empty", () => {
|
|
assert.deepEqual(relUrls(null), { bandcamp: null, spotify: null });
|
|
assert.deepEqual(relUrls([]), { bandcamp: null, spotify: null });
|
|
});
|
|
|
|
test("mbResult prefers direct links, falls back to search per-platform", () => {
|
|
const direct = mbResult(
|
|
{ name: "Cattle Decapitation" },
|
|
{ bandcamp: "https://cattledecapitation.bandcamp.com/", spotify: "https://open.spotify.com/artist/x" },
|
|
);
|
|
assert.equal(direct.bandcamp, "https://cattledecapitation.bandcamp.com/");
|
|
assert.equal(direct.spotify, "https://open.spotify.com/artist/x");
|
|
|
|
const fallback = mbResult({ name: "Cerebral Bore" }, null);
|
|
assert.equal(fallback.spotify, "https://open.spotify.com/search/Cerebral%20Bore");
|
|
assert.equal(fallback.bandcamp, "https://bandcamp.com/search?q=Cerebral%20Bore&item_type=b");
|
|
|
|
const partial = mbResult({ name: "X" }, { bandcamp: null, spotify: "https://open.spotify.com/artist/y" });
|
|
assert.equal(partial.spotify, "https://open.spotify.com/artist/y");
|
|
assert.match(partial.bandcamp, /bandcamp\.com\/search/);
|
|
});
|
|
|
|
test("link builders url-encode", () => {
|
|
assert.equal(spotifySearch("A B"), "https://open.spotify.com/search/A%20B");
|
|
assert.ok(bandcampSearch("A&B").includes("A%26B"));
|
|
});
|